Fix dynamic dependency array for useMemo
hook
#723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the React documentation,
useMemo
should receive a constant-length array of dependencies:Since we're currently passing parameters of the query to that hook (which can change when e.g. SQL and parameters are changed at once), React may emit a warning about "The final argument passed to
useMemo
changed size between renders. The order and size of this array must remain constant".I think that warning is harmless, but it's still something we should consider fixing.
So, this resolves that warning by:
checkQueryChanged
to avoid recomputing it there.