Capacitor Android CMakeLists Fix #759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Initial versions of the native Capacitor integration used SQLCipher from C to automatically register the PowerSync Rust Core. We no longer use this for Android - instead we register the extension via a SQLite statement.
Users reported build errors for a missing
CMakeLists.txtfile when testing Android. This is due to the file not being present in thepackage.jsonfilessection - causing the file not to be published to NPM. We don't need this C build anymore, so it's now been removed.The
example-capacitordemo has been upgraded to run in the Isolated Demo Tests in order to avoid publishing issues like this in future.