fix: Potential Multitab Transaction Issues With IndexedDB#775
Merged
stevensJourney merged 12 commits intomainfrom Nov 20, 2025
Merged
fix: Potential Multitab Transaction Issues With IndexedDB#775stevensJourney merged 12 commits intomainfrom
stevensJourney merged 12 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 8fc41a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
commented
Nov 20, 2025
stevensJourney
commented
Nov 20, 2025
stevensJourney
commented
Nov 20, 2025
rkistner
reviewed
Nov 20, 2025
Contributor
rkistner
left a comment
There was a problem hiding this comment.
Happy with the overall approach - just have a minor comment on the holds that may affect performance.
rkistner
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A db transaction death-loop could occur when using IndexedDB across multiple tabs, manifesting as the error:
This happens when a tab holding an active SQLite transaction is closed before committing or rolling back that transaction. Since IndexedDB shares a single SQLite connection (via a shared web worker) across all tabs, the uncommitted transaction persists and blocks subsequent transaction attempts.
Root Cause
BEGINstatements fail because a transaction is already in progressSolution
This PR implements a connection "hold" mechanism:
ROLLBACKto clean up the orphaned transactionThis ensures transactions are always resolved, even when tabs close unexpectedly.