-
Notifications
You must be signed in to change notification settings - Fork 60
Migrate PowerChat demo #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
8892fda to
080f9b3
Compare
| UpdateType, | ||
| type PowerSyncCredentials | ||
| } from "@powersync/react-native"; | ||
| import type { SupabaseClient } from "@supabase/supabase-js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few files have the incorrect string formatting.
| "@expo/vector-icons": "^15.0.3", | ||
| "@faker-js/faker": "^10.1.0", | ||
| "@journeyapps/react-native-quick-sqlite": "^2.4.11", | ||
| "@powersync/attachments": "^2.4.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is stealth changing the dropping of the "workspace" value.
Either we use workspace for this PR agains't main, or we target the the other PR's branch from this PR for now while reviewing.
The PowerChat demo (found here) is one of the older React Native demos in the repository. As such, it has naturally become less stable and harder to debug as PowerSync, Expo, React Native and other packages all increase their versions. This naturally leads to wanting to bump the package versions - however, some packages are so far behind that it would frankly be easier to start a new project and copy the application code, while also writing new config files that work with the latest packages.
This PR is a rewrite of the application using the latest compatible package versions and package configurations. Most of the app code is copied and should work the same, but most of the configuration code (Metro config, Babel config, Expo config) is new.
Also see PR #784, which is partially the reason this demo is being updated.