Skip to content

Conversation

simolus3
Copy link
Contributor

@simolus3 simolus3 commented Feb 20, 2025

This:

  1. Removes the use of Java toolchains for compiling code. These are "rarely a good idea" because newer JDKs are perfectly capable of emitting code for older JVMs (this is especially true for us since we only use Kotlin anyway).
  2. Uses Java 8 as a target for the JVM-specific KMP targets. We're still targeting Java 17 for Android, like before.
  3. Reformats code so that a clean ./gradlew build works. I'll look into why formatting isn't applied on the CI, but that's less time-critical.
  4. Upgrades stately to a version that supports Java 8.
  5. Run JVM tests for the core project on Java 8, in addition to the JVM used to build the project.

DominicGBauer
DominicGBauer previously approved these changes Feb 20, 2025
Copy link
Contributor

@DominicGBauer DominicGBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've tested this in the demo LGTM

@simolus3 simolus3 merged commit bbe0ecc into main Feb 20, 2025
3 checks passed
@simolus3 simolus3 deleted the chore/jdk8 branch February 20, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants