-
Notifications
You must be signed in to change notification settings - Fork 19
Improve Watch Queries #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm happy with the refactoring, and most of these comments are nits.
core/src/commonMain/kotlin/com/powersync/db/internal/InternalDatabaseImpl.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/powersync/db/internal/InternalDatabaseImpl.kt
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/powersync/db/internal/InternalDatabaseImpl.kt
Show resolved
Hide resolved
simolus3
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the watched query logic by optimizing table update handling, enhancing thread safety, and simplifying the implementation.
Table Update Optimization
Set
, preventing redundant entries. Since SQLite emits an update per row, the previous implementation could accumulate large arrays of duplicate table changes.Thread Safety for Table Updates
Implementation Cleanup
getAll
method instead of the driver’s synchronous methods.throttleMs
values per query.Removal of Blocking Calls
Testing
This was tested locally using both the Kotlin and Swift SDKs.
watches.mp4
Swift
Related Swift PR powersync-ja/powersync-swift#26