Refactor mutexes and duplicate instance detection logic #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the recently-added logic to warn for duplicate databases. The actual functionality is unchanged, but:
ActiveDatabaseGroup
).PowerSyncDatabase
, also guarddisconnect()
with a mutex. Since connecting, disconnecting and closing the database are all operations that can interfere with each other, I've used a single mutex for all of them.close()
being called. This can avoid a small memory leak. We should also investigate doing that on Java platforms, but convenient APIs are only available from Java 9+. So maybe something for another time...