-
Notifications
You must be signed in to change notification settings - Fork 19
Update Schema #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update Schema #154
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
939cdf5
Added ability to update schema
stevensJourney 2df9b6f
cleanup. Added changelog entries.
stevensJourney 2b55c17
Merge remote-tracking branch 'origin/main' into update-schema
stevensJourney a41ce45
store updated schema
stevensJourney 798f993
cleanup. ensureActive when requesting all connections
stevensJourney 1336b2f
cleanup
stevensJourney d812df4
update comment
stevensJourney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -267,7 +267,10 @@ class DatabaseTest { | |
|
||
// Any new readLocks should throw | ||
val exception = assertFailsWith<PowerSyncException> { database.readLock {} } | ||
assertEquals(expected = "Cannot process connection pool request", actual = exception.message) | ||
assertEquals( | ||
expected = "Cannot process connection pool request", | ||
actual = exception.message, | ||
) | ||
// Release the lock | ||
pausedLock.complete(Unit) | ||
lockJob.await() | ||
|
@@ -344,4 +347,79 @@ class DatabaseTest { | |
} | ||
assertEquals(expected = 0, actual = count) | ||
} | ||
|
||
@Test | ||
fun localOnlyCRUD() = | ||
runTest { | ||
database.updateSchema( | ||
schema = | ||
Schema( | ||
UserRow.table.copy( | ||
// Updating the existing "users" view to localOnly causes an error | ||
// no such table: main.ps_data_local__users. | ||
// Perhaps this is a bug in the core extension | ||
name = "local_users", | ||
localOnly = true, | ||
), | ||
), | ||
) | ||
|
||
database.execute( | ||
""" | ||
INSERT INTO | ||
local_users (id, name, email) | ||
VALUES | ||
(uuid(), "one", "[email protected]") | ||
""", | ||
) | ||
|
||
val count = database.get("SELECT COUNT(*) FROM local_users") { it.getLong(0)!! } | ||
assertEquals(actual = count, expected = 1) | ||
|
||
// No CRUD entries should be present for local only tables | ||
val crudItems = database.getAll("SELECT id from ps_crud") { it.getLong(0)!! } | ||
assertEquals(actual = crudItems.size, expected = 0) | ||
} | ||
|
||
@Test | ||
fun insertOnlyCRUD() = | ||
runTest { | ||
database.updateSchema(schema = Schema(UserRow.table.copy(insertOnly = true))) | ||
|
||
database.execute( | ||
""" | ||
INSERT INTO | ||
users (id, name, email) | ||
VALUES | ||
(uuid(), "one", "[email protected]") | ||
""", | ||
) | ||
|
||
val crudItems = database.getAll("SELECT id from ps_crud") { it.getLong(0)!! } | ||
assertEquals(actual = crudItems.size, expected = 1) | ||
|
||
val count = database.get("SELECT COUNT(*) from users") { it.getLong(0)!! } | ||
assertEquals(actual = count, expected = 0) | ||
} | ||
|
||
@Test | ||
fun viewOverride() = | ||
runTest { | ||
database.updateSchema(schema = Schema(UserRow.table.copy(viewNameOverride = "people"))) | ||
|
||
database.execute( | ||
""" | ||
INSERT INTO | ||
people (id, name, email) | ||
VALUES | ||
(uuid(), "one", "[email protected]") | ||
""", | ||
) | ||
|
||
val crudItems = database.getAll("SELECT id from ps_crud") { it.getLong(0)!! } | ||
assertEquals(actual = crudItems.size, expected = 1) | ||
|
||
val count = database.get("SELECT COUNT(*) from people") { it.getLong(0)!! } | ||
assertEquals(actual = count, expected = 1) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.