Skip to content

Conversation

stevensJourney
Copy link
Contributor

@stevensJourney stevensJourney commented Apr 3, 2025

Overview

This adds attachments helper functionality to the PowerSync Core module.

For full context. See the README

This implementation is a combination of the approach taken in the JS and Dart implementations.

  • The syncing strategy is adapted from JS. The Dart implementation requires developers to manually diff the watched attachments and local attachments state.
  • The JS implementation is a single, large, abstract class. This implementation borrows from the Dart implementation and splits the components into an AttachmentsService which handles Attachment state persisting and a Syncing service which processes the queue.
  • The AttachmentQueue here is not abstract, it provides a common and simple default implementation for certain operations. The class is open and can be extended if developers require custom functionality.

Demo

See the small video demonstrating syncing attachments between two devices

attachment_demo.mp4

TODOS

  • Complete unit tests
  • Use in demos
    • Added to Android Supabase Demo

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 45 out of 47 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • connectors/supabase/build.gradle.kts: Language not supported
  • core/build.gradle.kts: Language not supported
Comments suppressed due to low confidence (1)

core/README.md:27

  • Consider correcting 'it database API' to 'its database API' for proper grammatical accuracy.
of [SQLDelight](https://sqldelight.github.io/sqldelight/latest/) for it database API and typesafe database

Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes, the remaining comments are very minor items.

@stevensJourney stevensJourney marked this pull request as ready for review April 22, 2025 08:38
simolus3
simolus3 previously approved these changes Apr 22, 2025
Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@stevensJourney stevensJourney merged commit 5f32d69 into main Apr 22, 2025
3 checks passed
@stevensJourney stevensJourney deleted the attachments-package branch April 22, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants