Skip to content

Conversation

simolus3
Copy link
Contributor

Having a directory named PowerSyncKotlin/ in the root of the repository is somewhat confusing: It makes it sounds like that's where the PowerSync Kotlin SDK is, when in reality it's mostly unrelated to the Kotlin SDK.

Since we've recently introduced the internal/ folder for another subproject, that sounds like a good place to put the Swift SDK helper to tidy up the workspace a bit.

Copy link
Contributor

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd still need to update the deploy.yml actions for this new structure?

@simolus3
Copy link
Contributor Author

Good catch, thanks! Done.

Copy link
Contributor

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this. This is much nicer than the previous structure.

@simolus3 simolus3 merged commit 2090d59 into main Sep 30, 2025
8 checks passed
@simolus3 simolus3 deleted the make-swift-helper-internal branch September 30, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants