Skip to content

fix: custom write checkpoint logic #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix: custom write checkpoint logic #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9da43c7
fix: custom write checkpoint logic
stevensJourney Oct 29, 2024
9650b3d
chore: changelog entry and version bump
stevensJourney Oct 29, 2024
afb8837
Merge branch 'main' into fix/write-checkpoints
stevensJourney Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.0.0-BETA6

* Fix Custom Write Checkpoint application logic

## 1.0.0-BETA5

Expand Down
2 changes: 1 addition & 1 deletion core/src/commonMain/kotlin/com/powersync/db/PowerSyncDatabaseImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ internal class PowerSyncDatabaseImpl(
writeTransaction { tx ->
internalDb.queries.deleteEntriesWithIdLessThan(lastTransactionId.toLong())

if (writeCheckpoint != null && bucketStorage.hasCrud()) {
if (writeCheckpoint != null && !bucketStorage.hasCrud()) {
tx.execute(
"UPDATE ps_buckets SET target_op = CAST(? AS INTEGER) WHERE name='\$local'",
listOf(writeCheckpoint),
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ development=true
RELEASE_SIGNING_ENABLED=true
# Library config
GROUP=com.powersync
LIBRARY_VERSION=1.0.0-BETA5
LIBRARY_VERSION=1.0.0-BETA6
GITHUB_REPO=https://github.com/powersync-ja/powersync-kotlin.git
# POM
POM_URL=https://github.com/powersync-ja/powersync-kotlin/
Expand Down
Loading