Disable Skie SuspendInterop #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The setting to disable Skie SuspendInterop was removed in #75, this causes a compile time error in the Beta 6 as it requires the
__prefix when overriding suspend functions in Swift see this link for more details.This PR disables SuspendInterop as it was in Beta 5.
Work done
Testing
I tested this locally by generating a SPM dev build using the gradle script (
spmDevBuild) and linking thepowersync-kotlin-swift-demoto the local package. I confirmed that it fixes compile time errors and the demo runs as expected.