Skip to content

fix: race condition in transaction #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: race condition in transaction #91

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5fc2af
fix: race condition in transaction
DominicGBauer Dec 19, 2024
1753a32
chore: update package version
DominicGBauer Dec 19, 2024
6b2df6c
chore: update functions to make testing easier
DominicGBauer Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/iosMain/kotlin/com/powersync/DatabaseDriverFactory.ios.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import kotlinx.cinterop.asStableRef
import kotlinx.cinterop.staticCFunction
import kotlinx.cinterop.toKString
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.IO

@Suppress("EXPECT_ACTUAL_CLASSIFIERS_ARE_IN_BETA_WARNING")
@OptIn(ExperimentalForeignApi::class)
Expand Down Expand Up @@ -51,10 +53,13 @@ public actual class DatabaseDriverFactory {
scope: CoroutineScope,
dbFilename: String,
): PsSqlDriver {
val dbDispatcher = Dispatchers.IO
val dbScope = CoroutineScope(scope.coroutineContext + dbDispatcher)

val schema = InternalSchema.synchronous()
this.driver =
PsSqlDriver(
scope = scope,
scope = dbScope,
driver =
NativeSqliteDriver(
configuration =
Expand Down
Loading