-
Notifications
You must be signed in to change notification settings - Fork 25
Watch Active Checkpoint #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch Active Checkpoint #109
Conversation
…cture' into configurable-configuration
…mode after the fact
|
…cture' into configurable-configuration
The majority of the write checkpoint operations are specific to a specific set of sync rules (takes With that done, we could calculate the write checkpoint mode once when MongoSyncBucketStorage is instantiated, and don't need to watch for any changes. |
'fullDocument.last_checkpoint': 1, | ||
'fullDocument.last_checkpoint_lsn': 1 | ||
'fullDocument.last_checkpoint_lsn': 1, | ||
'fullDocument.content': 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has the potential to add a lot of overhead - the rest of the change stream is optimized to get checkpoint updates with as little latency as feasible. It also shouldn't be needed - the content of a sync rules document never change.
That does seem better. I've implemented that here. I'll close this PR since it will no longer be required. |
Overview
This builds on-top of #105.
This adds the ability to set the storage's Write Checkpoint mode after the storage's initialisation.
Setting the Write Checkpoint mode often depends on the active Sync rules. This adds a
watchActiveCheckpoint
method on theBucketStorage
which should yield the active checkpoint and active Sync Rules.This also adds plan parameters to the PowerSync config file.