Skip to content

Parse returned mysql schema result #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Parse returned mysql schema result #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02d078f
Bugfix:Parse returned schema info as an object. Previously this was t…
Rentacookie Nov 7, 2024
04d61dc
Added changeset
Rentacookie Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-rules-arrive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/service-module-mysql': patch
---

Fixed mysql schema json parsing
18 changes: 10 additions & 8 deletions modules/module-mysql/src/api/MySQLRouteAPIAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { toExpressionTypeFromMySQLType } from '../common/common-index.js';
type SchemaResult = {
schema_name: string;
table_name: string;
columns: Array<{ data_type: string; column_name: string }>;
columns: string;
};

export class MySQLRouteAPIAdapter implements api.RouteAPI {
Expand Down Expand Up @@ -326,16 +326,18 @@ export class MySQLRouteAPIAdapter implements api.RouteAPI {
name: result.schema_name,
tables: []
});

const columns = JSON.parse(result.columns).map((column: { data_type: string; column_name: string }) => ({
name: column.column_name,
type: column.data_type,
sqlite_type: toExpressionTypeFromMySQLType(column.data_type).typeFlags,
internal_type: column.data_type,
pg_type: column.data_type
}));

schema.tables.push({
name: result.table_name,
columns: result.columns.map((column) => ({
name: column.column_name,
type: column.data_type,
sqlite_type: toExpressionTypeFromMySQLType(column.data_type).typeFlags,
internal_type: column.data_type,
pg_type: column.data_type
}))
columns: columns
});

return hash;
Expand Down
Loading