Handle MySQL servers with non-UTC timezone #169
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests currently fail if the MySQL server is configured with a timezone other than UTC.
The issue is that MySQL always returns timestamps in the session timezone, without any timezone indicator. So there is no way to know what we should configure the client
timezonewith if we don't know the server timezone.The current tests also stored timestamps in the default/server timezone, but expected them to be returned in UTC timezone.
This changes:
+00:00timezone in literals.SET time_zone = "+00:00". This is somehow not needed for zongji. This is currently set on every query - not sure if there is a more efficient way to do this with a pool.