Added heartbeat to Mysql Binlog Listener connection #173
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06954d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rentacookie
commented
Jan 7, 2025
rkistner
reviewed
Jan 7, 2025
rkistner
previously approved these changes
Jan 7, 2025
|
Note: still needs a changeset. |
Fixed comment Co-authored-by: Ralf Kistner <[email protected]>
…afe' into mysql-connection-heartbeat-failsafe
rkistner
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that under some circumstance mysql replication stops without any errors, and only starts up correctly again when the powersync instance is restarted. We suspect that this may be happening to due an error on the replication connection that is not picked up by the Binlog listener.
This adds a heartbeat mechanism on the listener's replication connection to ensure we timeously pick up when the connection has stalled.