Error codes #176
Merged
Error codes #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 297d709 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stevensJourney
previously approved these changes
Jan 22, 2025
packages/service-core/src/entry/commands/test-connection-action.ts
Outdated
Show resolved
Hide resolved
stevensJourney
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to introduce consistent error codes throughout the entire service stack, in the form of
PSYNC_Sxxxxfor service errors, andPSYNC_Rxxxxfor sync rules errors.This refactors the error classes a bit to support this, and refactors an initial set of errors to use this new format. There are many cases not covered yet - can improve that over time.
The service-errors package contains a script to generate documentation for error codes from the source - see example here. This can be tweaked over time.
Some specific error messages have been improved:
value.get is not a functionwhen having an empty bucket (shows better error message now).There is now a "test-connection" action on the entry point that does the same connection validation as on the cloud service, which is also useful to test these error message changes.