Skip to content

Improve test stability #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Improve test stability #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f71083
Increase write checkpoint test timeout.
rkistner Feb 19, 2025
2757cbd
supercharge/[email protected], mongodb 8.0 by default.
rkistner Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ jobs:
- uses: actions/checkout@v4

- name: Start MongoDB
uses: supercharge/mongodb-github-action@1.8.0
uses: supercharge/mongodb-github-action@1.12.0
with:
mongodb-version: '6.0'
mongodb-version: '8.0'
mongodb-replica-set: test-rs

- name: Setup Node.js
Expand Down Expand Up @@ -117,9 +117,9 @@ jobs:
-d postgres:${{ matrix.postgres-version }}

- name: Start MongoDB
uses: supercharge/mongodb-github-action@1.8.0
uses: supercharge/mongodb-github-action@1.12.0
with:
mongodb-version: '6.0'
mongodb-version: '8.0'
mongodb-replica-set: test-rs

- name: Setup Node.js
Expand Down Expand Up @@ -183,9 +183,9 @@ jobs:
--server-id=1

- name: Start MongoDB
uses: supercharge/mongodb-github-action@1.8.0
uses: supercharge/mongodb-github-action@1.12.0
with:
mongodb-version: '6.0'
mongodb-version: '8.0'
mongodb-replica-set: test-rs

- name: Start PostgreSQL (Storage)
Expand Down Expand Up @@ -245,7 +245,7 @@ jobs:
- uses: actions/checkout@v4

- name: Start MongoDB
uses: supercharge/mongodb-github-action@1.8.0
uses: supercharge/mongodb-github-action@1.12.0
with:
mongodb-version: ${{ matrix.mongodb-version }}
mongodb-replica-set: test-rs
Expand Down
13 changes: 8 additions & 5 deletions modules/module-postgres/test/src/checkpoints.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { checkpointUserId, createWriteCheckpoint } from '@powersync/service-core
import { describe, test } from 'vitest';
import { INITIALIZED_MONGO_STORAGE_FACTORY } from './util.js';
import { WalStreamTestContext } from './wal_stream_utils.js';
import { env } from './env.js';

import timers from 'node:timers/promises';

Expand All @@ -11,8 +12,8 @@ const BASIC_SYNC_RULES = `bucket_definitions:
data:
- SELECT id, description, other FROM "test_data"`;

describe('checkpoint tests', () => {
test('write checkpoints', { timeout: 30_000 }, async () => {
describe.skipIf(!(env.CI || env.SLOW_TESTS))('checkpoint tests', () => {
test('write checkpoints', { timeout: 50_000 }, async () => {
const factory = INITIALIZED_MONGO_STORAGE_FACTORY;
await using context = await WalStreamTestContext.open(factory);

Expand Down Expand Up @@ -58,10 +59,12 @@ describe('checkpoint tests', () => {

const start = Date.now();
while (lastWriteCheckpoint == null || lastWriteCheckpoint < BigInt(cp.writeCheckpoint)) {
if (Date.now() - start > 2_000) {
throw new Error(`Timeout while waiting for checkpoint`);
if (Date.now() - start > 5_000) {
throw new Error(
`Timeout while waiting for checkpoint. last: ${lastWriteCheckpoint}, waiting for: ${cp.writeCheckpoint}`
);
}
await timers.setTimeout(0, undefined, { signal: controller.signal });
await timers.setTimeout(5, undefined, { signal: controller.signal });
}
}
} finally {
Expand Down