Use BigInt for OpId internally #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e94bc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our JSON protocol, we use strings to represent OpIds, since JS cannot reliably parse large numbers in JSON.
However, for internal usage, there was a mixture of string and bigint for that, leading in conversions between the two everywhere. This switches over to bigint in most places, only converting to return a response to the client. This results in less conversion between the two.
There are a small number of places where we use the large protocol types internally, and these do still use the string version.
This also fixes a couple of places where not-null or casts were incorrectly used, resulting in unexpected type mismatches at runtime. This specifically fixes an issue of MySQL BigLogStream tests not being setup correctly, as well as a race condition when stopping MySQL replication immediately after starting it.