Skip to content

[MySQL] Fix errors being hidden by ROLLBACK failure #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

[MySQL] Fix errors being hidden by ROLLBACK failure #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b91c5be
Avoid hiding original error on rollback error.
rkistner Mar 12, 2025
1bc9367
Add changeset.
rkistner Mar 12, 2025
9562d9e
Remove test code.
rkistner Mar 12, 2025
d1bd8ef
Merge branch 'main' into fix-mysql-error-hidden
rkistner Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fuzzy-items-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@powersync/service-module-mysql': patch
'@powersync/service-core': patch
'@powersync/service-image': patch
---

[MySQL] Fix errors being hidden by ROLLBACK failure
12 changes: 10 additions & 2 deletions modules/module-mysql/src/replication/BinLogStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class BinLogStream {
await this.snapshotTable(connection.connection, batch, result.table);
await promiseConnection.query('COMMIT');
} catch (e) {
await promiseConnection.query('ROLLBACK');
await tryRollback(promiseConnection);
throw e;
}
} finally {
Expand Down Expand Up @@ -292,7 +292,7 @@ AND table_type = 'BASE TABLE';`,
logger.info(`Initial replication done`);
await promiseConnection.query('COMMIT');
} catch (e) {
await promiseConnection.query('ROLLBACK');
await tryRollback(promiseConnection);
throw e;
} finally {
connection.release();
Expand Down Expand Up @@ -653,3 +653,11 @@ AND table_type = 'BASE TABLE';`,
}
}
}

async function tryRollback(promiseConnection: mysqlPromise.Connection) {
try {
await promiseConnection.query('ROLLBACK');
} catch (e) {
logger.error('Failed to rollback transaction', e);
}
}