-
Notifications
You must be signed in to change notification settings - Fork 25
SDK Schema Generators #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f01c062 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new schema generators for the Kotlin, Swift, and .Net SDKs, along with updates to file exports and associated tests.
- Added tests for schema generation in Kotlin, Swift, and .Net.
- Introduced new generator classes: KotlinSchemaGenerator, SwiftSchemaGenerator, DotNetSchemaGenerator.
- Updated the export infrastructure to include the new generators.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/sync-rules/test/src/generate_schema.test.ts | Added tests validating schema generation for Kotlin, Swift, and .Net using new generators. |
packages/sync-rules/src/schema-generators/schema-generators.ts | Updated exports to include new generator modules. |
packages/sync-rules/src/schema-generators/generators.ts | Added imports and registrations for Kotlin, Swift, and DotNet generators. |
packages/sync-rules/src/schema-generators/TsSchemaGenerator.ts | Adjusted import paths to match updated project structure. |
packages/sync-rules/src/schema-generators/SwiftSchemaGenerator.ts | New implementation for Swift schema generation. |
packages/sync-rules/src/schema-generators/SchemaGenerator.ts | Updated common helper function for generating column types. |
packages/sync-rules/src/schema-generators/KotlinSchemaGenerator.ts | New implementation for Kotlin schema generation. |
packages/sync-rules/src/schema-generators/JsLegacySchemaGenerator.ts | Updated import paths. |
packages/sync-rules/src/schema-generators/DotNetSchemaGenerator.ts | New implementation for .Net schema generation with a custom helper function for column types. |
packages/sync-rules/src/schema-generators/DartSchemaGenerator.ts | Updated to use the common column type helper. |
packages/sync-rules/src/index.ts | Updated export list to include schema generators under a common module. |
.changeset/beige-poems-share.md | Changeset describing the addition of new schema generators. |
Comments suppressed due to low confidence (1)
packages/sync-rules/src/schema-generators/DotNetSchemaGenerator.ts:56
- [nitpick] Consider encapsulating the helper function 'cSharpColumnType' as a private method inside the DotNetSchemaGenerator class for consistency with the approach used in other schema generators.
return `{ "${column.name}", ${cSharpColumnType(column)} }`;
Overview
This adds Schema generators for the Kotlin, Swift and DotNet SDKs
Related https://github.com/journeyapps-platform/ide/pull/1105
Kotlin
Swift
.Net