Skip to content

Fix missing parameter storage metrics #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

Fix missing parameter storage metrics #252

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4c3a5f
Report 0 storage metrics instead of ignoring them.
Rentacookie Apr 30, 2025
5f48921
Added changeset
Rentacookie Apr 30, 2025
b25d531
Reverted storage metric changes
Rentacookie Apr 30, 2025
87c61b9
Updated changeset
Rentacookie Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-ties-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/service-core': patch
---

Always report 0 value storage metrics
8 changes: 4 additions & 4 deletions packages/service-core/src/storage/storage-metrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function initializeCoreStorageMetrics(engine: MetricsEngine, storage: Buc
let cacheTimestamp = 0;

const getMetrics = () => {
if (cachedRequest == null || Date.now() - cacheTimestamp > MINIMUM_INTERVAL) {
if (!cachedRequest || Date.now() - cacheTimestamp > MINIMUM_INTERVAL) {
cachedRequest = storage.getStorageMetrics().catch((e) => {
logger.error(`Failed to get storage metrics`, e);
return null;
Expand All @@ -47,21 +47,21 @@ export function initializeCoreStorageMetrics(engine: MetricsEngine, storage: Buc
replication_storage_size_bytes.setValueProvider(async () => {
const metrics = await getMetrics();
if (metrics) {
return metrics.replication_size_bytes;
return metrics.replication_size_bytes ?? 0;
}
});

operation_storage_size_bytes.setValueProvider(async () => {
const metrics = await getMetrics();
if (metrics) {
return metrics.operations_size_bytes;
return metrics.operations_size_bytes ?? 0;
}
});

parameter_storage_size_bytes.setValueProvider(async () => {
const metrics = await getMetrics();
if (metrics) {
return metrics.parameters_size_bytes;
return metrics.parameters_size_bytes ?? 0;
}
});
}