Skip to content

Conversation

@simolus3
Copy link
Contributor

The data field in OplogEntry will always be a nullable string, we don't store contents as an object directly.

This was a bit confusing to me when writing the new sync client for the core extension, I thought the Record representation was something we had to deal with. This fixes the type annotations to make it clear that that's not true.

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: 100ccec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@powersync/service-core Patch
@powersync/service-core-tests Patch
@powersync/service-module-core Patch
@powersync/service-module-mongodb-storage Patch
@powersync/service-module-mongodb Patch
@powersync/service-module-mysql Patch
@powersync/service-module-postgres-storage Patch
@powersync/service-module-postgres Patch
@powersync/service-image Patch
test-client Patch
@powersync/service-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@rkistner rkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this does help clarify it

@simolus3 simolus3 merged commit cfc6a4f into main May 22, 2025
21 checks passed
@simolus3 simolus3 deleted the clarify-oplog-entry-format branch May 22, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants