Skip to content

Conversation

@rkistner
Copy link
Contributor

Replication lag metric was introduced in #272 (not released yet).

This fixes an issue where the replication lag metric could keep on growing indefinitely after initial replication, if no other changes come in at that time.

The issue is that in the case of "Commit due to keepalive", the "oldest uncommitted change" was not cleared, even though we have nothing further to write. This fixes the issue.

Sample of what happened:
image

The sharp increase at 16:23 is when the initial snapshot is completed, and the drop at 17:20 is when another write was made to the source db, clearing the replication lag.

@rkistner rkistner requested a review from stevensJourney June 18, 2025 15:27
@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: 8da22a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rkistner rkistner merged commit bd08d2e into main Jun 19, 2025
35 of 36 checks passed
@rkistner rkistner deleted the fix-replication-lag branch June 19, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants