Skip to content

Conversation

@simolus3
Copy link
Contributor

The stream-related tests in BucketChecksumState.test.ts use a mocked stream implementation because I've written that test before implementing streams.

Now that streams are available, we can use actual streams parsed from yaml for those tests.

@simolus3 simolus3 requested a review from rkistner August 21, 2025 11:46
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

⚠️ No Changeset found

Latest commit: d30790e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@simolus3 simolus3 merged commit ee3c3f2 into main Aug 21, 2025
21 checks passed
@simolus3 simolus3 deleted the checksum-state-test-use-streams branch August 21, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants