Pre-pull mongodb image in CI to use authenticated docker credentials #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#298 added "Docker login" to all CI actions, but unfortunately it did not take effect on the MongoDB images used by
supercharge/mongodb-github-action
. This resulted in frequent errors like these when running the actions:This adds a "pre-pull" before starting MongoDB, so that the image is already cached before starting it.
We can confirm it has an effect by looking at the runtime of the actions: Before it would take around 12s for "Start MongoDB". Now it takes around 9s for "Pre-pull Mongo image", and 3s for "Start MongoDB", confirming that it does use the cached image.