More checksum calculation fixes #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#351 fixed some checksum-related issues, but introduced others.
These were cases not caught by the current tests, since it did not fully cover all cases of partial checksum responses. My manual testing did also not pick this up since I mostly focused on testing a single large bucket. New tests cover this properly now. The tests depend on random ordering on MongoDB so individual tests were not failing consistently, but combining them all it did always cause some failures at least.
This was caused by two issues:
batchCount++
that should never have been there.$group
results will be sorted if the input is sorted - that was not the case.This fixes it.