Skip to content

Conversation

rkistner
Copy link
Contributor

@rkistner rkistner commented Sep 3, 2025

#351 fixed some checksum-related issues, but introduced others.

These were cases not caught by the current tests, since it did not fully cover all cases of partial checksum responses. My manual testing did also not pick this up since I mostly focused on testing a single large bucket. New tests cover this properly now. The tests depend on random ordering on MongoDB so individual tests were not failing consistently, but combining them all it did always cause some failures at least.

This was caused by two issues:

  1. A batchCount++ that should never have been there.
  2. Assuming $group results will be sorted if the input is sorted - that was not the case.

This fixes it.

Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: ed336fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@powersync/service-module-mongodb-storage Patch
@powersync/service-core-tests Patch
@powersync/service-core Patch
@powersync/service-image Patch
@powersync/service-schema Patch
@powersync/service-module-mongodb Patch
@powersync/service-module-mysql Patch
@powersync/service-module-postgres Patch
@powersync/service-module-postgres-storage Patch
@powersync/service-module-core Patch
test-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rkistner rkistner requested a review from simolus3 September 3, 2025 15:10
Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix and associated tests make sense to me 👍

@rkistner rkistner merged commit f1b4cef into main Sep 3, 2025
21 checks passed
@rkistner rkistner deleted the fix-checksums-2 branch September 3, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants