Warn when auto-subscribe streams use parameters #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a default sync stream uses a subscription parameter, that parameter will always be
null
. This makesauto_subscribe: true
streams with parameters kind of useless.Since this behavior is somewhat confusing (see this discord thread), it's better to warn about it. So this, tracks the use of
subscription
parameters in compiled clauses and then warns if they're used in a default stream.