[Feature] Configurable metrics #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f90ba2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Closing this stale PR. superseded by #221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metrics on Container
This moves the
Metricsimplementation from a class singleton to the frameworkContainer.This allows for constructing different
Metricsimplementations which can be registered during project initialization.Code in the
@powersync/service-corepackage can fetch the registeredMetricsimplementation easily without any massive refactoring - this approach is subject to change when a modules system is implemented.Extendable Config
Extended Metrics implementations will require extended PowerSyncConfig which is collected by a
CompoundConfigCollector. This class is now made extendable and generic. Downstream services can implement their own additional validation, decoding and resolving of config.