Skip to content

Fix uninitialized tag #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Fix uninitialized tag #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60f6414
Initialize tag variable before use in nested function call.
Rentacookie Oct 3, 2024
04937a8
Add comment for tag default value
Rentacookie Oct 3, 2024
e4d19b2
Changeset
Rentacookie Oct 3, 2024
b8dfc98
Comment update
Rentacookie Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-spoons-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/service-core': patch
---

Moved tag variable initialization in diagnostics route to ensure it is initialized before usage
9 changes: 5 additions & 4 deletions packages/service-core/src/api/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ export async function getSyncRulesStatus(
};
}

const sourceConfig = await apiHandler.getSourceConfig();
// This method can run under some situations if no connection is configured yet.
// It will return a default tag in such a case. This default tag is not module specific.
const tag = sourceConfig.tag ?? DEFAULT_TAG;
const systemStorage = live_status ? bucketStorage.getInstance(sync_rules) : undefined;
const status = await systemStorage?.getStatus();
let replication_lag_bytes: number | undefined = undefined;
Expand Down Expand Up @@ -128,15 +132,12 @@ export async function getSyncRulesStatus(
})
);

const sourceConfig = await apiHandler.getSourceConfig();
const tag = sourceConfig.tag ?? DEFAULT_TAG;

return {
content: include_content ? sync_rules.sync_rules_content : undefined,
connections: [
{
id: sourceConfig.id ?? DEFAULT_DATASOURCE_ID,
tag: sourceConfig.tag ?? DEFAULT_TAG,
tag: tag,
slot_name: sync_rules.slot_name,
initial_replication_done: status?.snapshot_done ?? false,
// TODO: Rename?
Expand Down
Loading