Conversation
simolus3
commented
Mar 5, 2026
simolus3
force-pushed
the
raw-table-improvements
branch
from
d831650 to
5fd9585
Compare
Contributor
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
Had some minor comments. Overall looks good to me.
stevensJourney
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the Kotlin PR to Swift:
RawTableconstructor takes aRawTableSchemastruct describing the local table name. This allows inferring theputanddeletestatements.putstatements, the.restparameter source is available to generate a JSON object of remaining columns.This also makes use of a new feature exposed in Kotlin to make
:memory:databases actually be in-memory instead of writing to a file named:memory:.