Skip to content

Handle PowersyncNotReadyException printing the message for the user #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Handle PowersyncNotReadyException printing the message for the user #170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aee6372
Handle `PowersyncNotReadyException` printing the message for the user
mugikhan Sep 19, 2024
8e926d6
Rethrow exception
mugikhan Sep 19, 2024
dc05062
Revert imports
mugikhan Sep 19, 2024
6f9f2b8
Fix imports
mugikhan Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/powersync/lib/src/database/powersync_db_mixin.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,12 @@ import 'dart:async';

import 'package:logging/logging.dart';
import 'package:meta/meta.dart';
import 'package:powersync/powersync.dart';
import 'package:powersync/sqlite3_common.dart';
import 'package:powersync/sqlite_async.dart';
import 'package:powersync/src/abort_controller.dart';
import 'package:powersync/src/connector.dart';
import 'package:powersync/src/crud.dart';
import 'package:powersync/src/powersync_update_notification.dart';
import 'package:powersync/src/schema.dart';
import 'package:powersync/src/schema_logic.dart';
import 'package:powersync/src/sync_status.dart';

mixin PowerSyncDatabaseMixin implements SqliteConnection {
/// Schema used for the local database.
Expand Down
21 changes: 13 additions & 8 deletions packages/powersync/lib/src/open_factory/native/native_open_factory.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ class PowerSyncOpenFactory extends AbstractPowerSyncOpenFactory {
@Deprecated('Override PowerSyncOpenFactory instead.')
final SqliteConnectionSetup? _sqliteSetup;

PowerSyncOpenFactory(
{required super.path,
super.sqliteOptions,
@Deprecated('Override PowerSyncOpenFactory instead.')
SqliteConnectionSetup? sqliteSetup})
// ignore: deprecated_member_use_from_same_package
: _sqliteSetup = sqliteSetup;
PowerSyncOpenFactory({
required super.path,
super.sqliteOptions,
@Deprecated('Override PowerSyncOpenFactory instead.')
SqliteConnectionSetup? sqliteSetup,
})
// ignore: deprecated_member_use_from_same_package
: _sqliteSetup = sqliteSetup;

@override
void enableExtension() {
Expand Down Expand Up @@ -66,7 +67,11 @@ class PowerSyncOpenFactory extends AbstractPowerSyncOpenFactory {
// ignore: deprecated_member_use_from_same_package
_sqliteSetup?.setup();

enableExtension();
try {
enableExtension();
} on PowersyncNotReadyException catch (e) {
autoLogger.severe(e.message);
}

var db = super.open(options);
db.execute('PRAGMA recursive_triggers = TRUE');
Expand Down
Loading