Fix broken token invalidation on web #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
force-pushed
the
fix-token-expiry-web
branch
from
458ddae to
ca2a752
Compare
simolus3
commented
Mar 10, 2025
stevensJourney
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported here. When the sync service calls
invalidCredentialsCallback, the app should fetch new credentials which are then cached by the connector. For this, we need to callprefetchCredentials.fetchCredentials, the method we used to call, obtains credentials without saving them.We were already calling
prefetchCredentialson native platforms, but the web implementation was broken and never refreshed the token. This caused us to keep using the expired token, entering an infinite loop of 401 errors.