Skip to content

Refactor connection locks #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025
Merged

Refactor connection locks #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b4430b
Refactor connect/disconnect logic
simolus3 Apr 15, 2025
db430d8
Refactor locks and retry logic around connect
simolus3 Apr 15, 2025
3387dc0
Await isolate exit once we try spawning it
simolus3 Apr 15, 2025
87759eb
Adopt isolate mutex implementations
simolus3 Apr 22, 2025
087b5d5
Share crud and sync mutexes
simolus3 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/powersync_core/lib/src/abort_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ class AbortController {
return _abortRequested.future;
}

Future<void> get onCompletion {
return _abortCompleter.future;
}

/// Abort, and wait until aborting is complete.
Future<void> abort() async {
aborted = true;
Expand Down
13 changes: 11 additions & 2 deletions packages/powersync_core/lib/src/database/active_instances.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,23 @@ final class ActiveDatabaseGroup {

/// Use to prevent multiple connections from being opened concurrently
final Mutex syncConnectMutex = Mutex();
final Mutex syncMutex;
final Mutex crudMutex;

final String identifier;

ActiveDatabaseGroup._(this.identifier);
ActiveDatabaseGroup._(this.identifier)
: syncMutex = Mutex(identifier: '$identifier-sync'),
crudMutex = Mutex(identifier: '$identifier-crud');

void close() {
Future<void> close() async {
if (--refCount == 0) {
final removedGroup = _activeGroups.remove(identifier);
assert(removedGroup == this);

await syncConnectMutex.close();
await syncMutex.close();
await crudMutex.close();
}
}

Expand Down
Loading