Fix reconnecting after checksum failure #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
force-pushed
the
fix-reconnect-after-checksum-failure
branch
from
3c2d004 to
ba335b8
Compare
rkistner
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #281, I've moved the core switch statement handling different sync lines into a separate method responsible for handling a single line. Unfortunately, I've missed that this changes the semantics of
breakandreturnstatements, which previously interrupted a sync iteration and now do nothing 😬This fixes the issue by setting a boolean variable to break out of the sync iteration, I've also added two new test cases for these scenarios.