Skip to content

Fix http error parsing #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Fix http error parsing #295

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8396e
Fix http error parsing.
rkistner Jul 2, 2025
f36a41a
Extract common logic.
rkistner Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/powersync_core/lib/src/exceptions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class SyncResponseException implements Exception {
final details = _stringOrFirst(decoded['error']?['details']) ?? body;
final message = '${response.reasonPhrase ?? "Request failed"}: $details';
return SyncResponseException(response.statusCode, message);
} on Error catch (_) {
} on Exception catch (_) {
return SyncResponseException(
response.statusCode,
response.reasonPhrase ?? "Request failed",
Expand All @@ -58,12 +58,7 @@ class SyncResponseException implements Exception {
final details = _stringOrFirst(decoded['error']?['details']) ?? body;
final message = '${response.reasonPhrase ?? "Request failed"}: $details';
return SyncResponseException(response.statusCode, message);
} on FormatException catch (_) {
return SyncResponseException(
response.statusCode,
response.reasonPhrase ?? "Request failed",
);
} on Error catch (_) {
} on Exception catch (_) {
return SyncResponseException(
response.statusCode,
response.reasonPhrase ?? "Request failed",
Expand Down