[Chore] Update fork #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IDBMirrorVFS to benchmarks link.
Add IDBMirrorVFS to hello demo.
Defer IDBMirrorVFS and OPFSPermutedVFS broadcasts.
Fix rhashimoto#187. Add clear_bindings().
Update package.json
Bumps [@75lb/deep-merge](https://github.com/75lb/deep-merge) from 1.1.1 to 1.1.2. - [Commits](75lb/deep-merge@v1.1.1...v1.1.2) --- updated-dependencies: - dependency-name: "@75lb/deep-merge" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…yarn/75lb/deep-merge-1.1.2 Bump @75lb/deep-merge from 1.1.1 to 1.1.2
stevensJourney
commented
Sep 5, 2024
stevensJourney
commented
Sep 5, 2024
| @@ -1,4 +1,5 @@ | |||
| # dependencies | |||
| # TODO this should be 3.46.0, but there are build errors | |||
| SQLITE_VERSION = version-3.44.0 | |||
There was a problem hiding this comment.
I'm not sure why this fails for 3.46.0. It seems like this error might be coming from our rust core
1 task
rkistner
reviewed
Sep 5, 2024
Comment on lines
+228
to
231
| return sqlite3_vfs_register(&vfs->base, makeDefault); | ||
| } | ||
|
|
||
| int setup_powersync() |
There was a problem hiding this comment.
Not directly related to this PR, but can the powersync setup be moved to main.c? libvfs.c is a weird place for it
There was a problem hiding this comment.
Agreed. Will update.
|
Superseded by #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This updates the fork from upstream.
Testing
Verified that the demo loads the SQLite core extension correctly.
