fix: add attachment name in download endpoint#147
Merged
TheMaskedTurtle merged 4 commits intomainfrom Jan 28, 2026
Merged
Conversation
TheMaskedTurtle
force-pushed
the
jorism/fix/swagger-download
branch
2 times, most recently
from
d0d91e4 to
effd882
Compare
TheMaskedTurtle
changed the title
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
jorism/fix/swagger-download
branch
from
effd882 to
f11ef9f
Compare
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
|
etiennehomer
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Enhancement
What is the current behavior?
Downloading a file via swagger will not download the file with the proper name
What is the new behavior (if this is a feature change)?
Add the attachment name in the headers so that it downloads it properly
Does this PR introduce a breaking change or deprecate an API?