Merged
Conversation
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
EtienneLt
reviewed
Feb 7, 2025
| LOGGER.debug("importCase request received with file = {}", file.getName()); | ||
| UUID caseUuid = caseService.importCase(file, withExpiration, withIndexation); | ||
| UUID caseUuid = UUID.randomUUID(); | ||
| caseService.importCase(file, withExpiration, withIndexation, caseUuid); |
Collaborator
There was a problem hiding this comment.
so you are creating a randomuuid ? the db is not doing it automaticaly ?
Collaborator
There was a problem hiding this comment.
ok I think I see instead of generating in service it is generated there
ghazwarhili
reviewed
Feb 7, 2025
src/main/java/com/powsybl/caseserver/migration/MigrationController.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/caseserver/datasource/AbstractCaseDataSourceControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/caseserver/datasource/AbstractCaseDataSourceControllerTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/caseserver/migration/MigrationController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/caseserver/migration/MigrationController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
…-case-server into migration_python
ghazwarhili
approved these changes
Feb 7, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Add an endpoint for cases migration that allow to import a case with a given UUID
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
The server generates the case UUID.
Does this PR introduce a breaking change or deprecate an API?