-
Notifications
You must be signed in to change notification settings - Fork 51
Improve CGMES importer logs #3705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Damien Jeandemange <[email protected]>
|
|
||
| private void warnDanglingLineCreated() { | ||
| fixed("Dangling line with low impedance", "Connected to a boundary node"); | ||
| fixed("Converted as a dangling line with zero impedance", "Connected to a boundary node"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to just an info log, or even debug, or even remove completely, this behavior is described in the CGMES import documentation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates a warn severity level log, which is usually used when an inconsistent or incomplete data is fixed. Here there is no inconsistency, this is the standard conversion process and it is documented as you pointed out, so I'm ok to change this to an info severity level log.
I think however it is important to keep this as an info and not a debug log, as users often tend to hide the debug logs and they might struggle to understand why their CGMES boundary switch is not visible in the IIDM switches.
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
|
still some uncovered cases about OperationalLimits ... returning to draft |
|
|
|
||
| private void warnDanglingLineCreated() { | ||
| fixed("Dangling line with low impedance", "Connected to a boundary node"); | ||
| fixed("Converted as a dangling line with zero impedance", "Connected to a boundary node"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates a warn severity level log, which is usually used when an inconsistent or incomplete data is fixed. Here there is no inconsistency, this is the standard conversion process and it is documented as you pointed out, so I'm ok to change this to an info severity level log.
I think however it is important to keep this as an info and not a debug log, as users often tend to hide the debug logs and they might struggle to understand why their CGMES boundary switch is not visible in the IIDM switches.


Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
"inconvenience" fixes
What is the current behavior?
lots of confusing logs:
Mostly about Operational Limits ending in practice in the following form:
Caused by OperationalLimits on equipements not supported. For switches we get only the second message.
logs with an empty reason end with
<some issue> . Reason:superfluous warning about missing name on cim:TieFlow-s
superfluous warning cim:Switch connected to boundary point (perfectly valid in CGMES, and supported by the importer)
What is the new behavior (if this is a feature change)?
... Reason:anymore.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: