add controls on rates for generatorStartUp extension #3716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolnico
requested changes
Jan 30, 2026
Comment on lines
70
to
74
| if (plannedOutageRate > 1) { | ||
| plannedOutageRate = 1; | ||
| } else if (plannedOutageRate < 0) { | ||
| plannedOutageRate = 0; | ||
| } |
Member
There was a problem hiding this comment.
Could you use a small method to avoid code duplication?
For example:
private double readOutageRate(DeserializerContext context, String attributeName) {
double outageRate = context.getReader().readDoubleAttribute(attributeName);
// compatibility
if (outageRate > 1) {
outageRate = 1.0;
} else if (outageRate < 0) {
outageRate = 0.0;
}
return outageRate;
}| } | ||
|
|
||
| public static void checkRate(Validable validable, String validableType, double rate, String fieldName) { | ||
| if (!Double.isNaN(rate) && (rate < 0 || rate > 1)) { |
Member
There was a problem hiding this comment.
Could the values be defined as a public static variables somewhere, in order to avoid having the values in multiple places directly in the code?
| @@ -0,0 +1,45 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <iidm:network xmlns:iidm="http://www.powsybl.org/schema/iidm/1_15" xmlns:gs="http://www.powsybl.org/schema/iidm/ext/generator_startup/1_1" id="sim1" caseDate="2026-01-14T10:21:31.745Z" forecastDistance="0" sourceFormat="test" minimumValidationLevel="STEADY_STATE_HYPOTHESIS"> | |||
Member
There was a problem hiding this comment.
Suggested change
| <iidm:network xmlns:iidm="http://www.powsybl.org/schema/iidm/1_15" xmlns:gs="http://www.powsybl.org/schema/iidm/ext/generator_startup/1_1" id="sim1" caseDate="2026-01-14T10:21:31.745Z" forecastDistance="0" sourceFormat="test" minimumValidationLevel="STEADY_STATE_HYPOTHESIS"> | |
| <iidm:network xmlns:iidm="http://www.powsybl.org/schema/iidm/1_16" xmlns:gs="http://www.powsybl.org/schema/iidm/ext/generator_startup/1_1" id="sim1" caseDate="2026-01-14T10:21:31.745Z" forecastDistance="0" sourceFormat="test" minimumValidationLevel="STEADY_STATE_HYPOTHESIS"> |
EtienneLt
force-pushed
the
add-controls-on-rates
branch
2 times, most recently
from
13348a9 to
6c03064
Compare
rolnico
requested changes
Feb 2, 2026
Member
rolnico
left a comment
rolnico
left a comment
There was a problem hiding this comment.
commit history + DCO have to be fixed
|
|
||
| public static void checkRate(Validable validable, String validableType, double rate, String fieldName) { | ||
| if (!Double.isNaN(rate) && (rate < MIN_RATE || rate > MAX_RATE)) { | ||
| throw new ValidationException(validable, "Unexpected value for " + fieldName + " of " + validableType + " : " + rate + " is not included in [0, 1]"); |
Member
There was a problem hiding this comment.
Use the constants in the message too
| private double readOutageRate(DeserializerContext context, String attributeName) { | ||
| double outageRate = context.getReader().readDoubleAttribute(attributeName); | ||
| // compatibility | ||
| if (outageRate > 1) { |
| assertEquals(5.0, generatorStartup.getStartupCost()); | ||
| assertEquals(10.0, generatorStartup.getMarginalCost()); | ||
| // planned outage rate is greater than 1 so it is set to 1 | ||
| assertEquals(1, generatorStartup.getPlannedOutageRate()); |
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: EtienneLt <[email protected]>
EtienneLt
force-pushed
the
add-controls-on-rates
branch
from
f416c34 to
0dcf9d2
Compare
Signed-off-by: Etienne LESOT <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
for the extension GeneratorStartUp, there is no control on rate fields. But they should be between 0 and 1 to be coherent
What is the new behavior (if this is a feature change)?
add tests
Does this PR introduce a breaking change or deprecate an API?
Other information:
we try to keep compatibility with the SerDe. if in a network there is a value below 0 it is set to 0 and if the value is higher than 1 it is set to 1