Add new GeneratorEntsoeCategory extension version that allows code value of 0 #3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu SAUR <[email protected]>
… version 1.15 -> 1.16) Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: Matthieu SAUR <[email protected]>
…lue of 0 Signed-off-by: Romain Courtier <[email protected]>
Signed-off-by: Romain Courtier <[email protected]>
|
rolnico
requested changes
Jan 19, 2026
Comment on lines
+52
to
+59
| @Override | ||
| public boolean isValid(GeneratorEntsoeCategory entsoeCategory, SerializerContext context) { | ||
| if (entsoeCategory.getCode() == 0 && getExtensionVersionToExport(context) == Version.V_1_0) { | ||
| LOGGER.warn("Extension entsoeCategory not valid for Generator: {}. Reason: code = 0 not allowed in version 1.0.", | ||
| entsoeCategory.getExtendable().getId()); | ||
| return false; | ||
| } | ||
| return true; |
Member
There was a problem hiding this comment.
Instead of adding a new isValid method, you could override the existing isSerializable method.
See for example the override in MeasurementsSerDe:
@Override
public boolean isSerializable(Measurements<C> extension) {
return !extension.getMeasurements().isEmpty();
}
github-project-automation
bot
moved this from In Progress
to Waiting for review
in Release 03/2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
Bug fix + doc update.
What is the current behavior?
Generator's extension GeneratorEntsoeCategory with code = 0 is not allowed (min value is 1).
What is the new behavior (if this is a feature change)?
GeneratorEntsoeCategory extension has a new version (v1.1) that allows code = 0 (min value is 0).
Backward compatibililty is ensured, although when trying to serialize a code = 0 in the legacy version (v1.0), the extension is not written and a warning log is generated.
Does this PR introduce a breaking change or deprecate an API?
Other information:
Generators with code equal to 0 represent synchronous condenser.