-
Notifications
You must be signed in to change notification settings - Fork 54
Multiple active operational limits group #3735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NathanDissoubray
wants to merge
110
commits into
main
Choose a base branch
from
3703-2-multiple_active_operational_limits_group
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
110 commits
Select commit
Hold shift + click to select a range
25ff548
Modify FlowsLimitsHolder API to manage multiple active OperationalLim…
NathanDissoubray b71f560
Update Impls that are easy to update
NathanDissoubray 0fa38a1
Modify OperationalLimitsGroup(s)Impl
NathanDissoubray 497d475
Add a addSelected method and to keep same expected results with setSe…
NathanDissoubray 673f9c4
Modify checkLimitViolation to get multiple Overload instead of a sing…
NathanDissoubray b36f24a
Implement methods for security needed to handle multiple limits, apar…
NathanDissoubray 940fd40
Rename getAllSelectedOperationalLimitsGroup -> ...Groups
NathanDissoubray 0df8345
Add methods to get Active,Apparent,Current limits from an id
NathanDissoubray 6270e7f
Rename getSelectedOrThrow to getOperationalLimitsGroupOrThrow in OpLi…
NathanDissoubray cc5aa65
Remove TODO
NathanDissoubray 5c3db00
Add back constructor of OperationalLimitsGroupImpl with a string and …
NathanDissoubray 81c500b
Remove unneeded blank line
NathanDissoubray f6092a4
Replace usage of string collection by a predicate in OperationalLimit…
NathanDissoubray 8bf6b68
Add missing . in error message
NathanDissoubray 261f236
Simplify calls to functions getting a given side for the limits
NathanDissoubray 1bf8ee0
Remove notification of deselection on setSelected if the group is alr…
NathanDissoubray b6459c9
LimitsComputer adaptations
olperr1 f11157f
Modify getLoadingLimits and getAllSelectedLoadingLimits to a simpler …
NathanDissoubray 6be65dc
Replace collect(Collectors.toList()) by toList()
NathanDissoubray c4e921b
Clean function name and predicate useage in OperationalLimitsGroupsIm…
NathanDissoubray 6d1859a
Checkstyle
NathanDissoubray ed032a9
Overload have the id of the limits group they are related to
NathanDissoubray 6fabc50
Add method to return all the ids of the side of a branch from the bra…
NathanDissoubray c25731f
Add javadoc
NathanDissoubray 1b3884f
Change some private functions in LimitViolationUtils to public, make …
NathanDissoubray 82a2468
Rewrite checkLimitViolation to handle multiple groups
NathanDissoubray 96a14bf
Fix logic error with naming of group in overload construction
NathanDissoubray 5f2837d
Fix forgotten filtering of overloading on permanent limits
NathanDissoubray 1e35b7c
Add ability to deselect multiple groups at once
NathanDissoubray 30d4ba7
Add functions to add and deselect groups directly from a branch
NathanDissoubray a60ce89
Modify the DefaultLimitViolationDetector to use methods in LimitViola…
NathanDissoubray d02cb0f
Modify LimitViolationDetector to use LimitViolationDetection
NathanDissoubray 36a9434
Modify LimitViolationDetector on temporary to also use LimitViolation…
NathanDissoubray 293bb09
Add operationalGroupId and the value of the permanent limit in the pe…
NathanDissoubray 4a72244
Add a test to check multiple activated limits group
NathanDissoubray 547983d
Write some parameterized tests for the multiple active groups
NathanDissoubray 5c64fa5
Add more test case to parameterized test
NathanDissoubray 7c56b77
Merge branch 'main' into 3703-2-multiple_active_operational_limits_group
NathanDissoubray 2d0e7ea
serde modify both xsd to take multiple selected limits group
NathanDissoubray eb0899e
Modify branch to have add and deselect use side like get
NathanDissoubray f5815f3
Serde for multiple selected operational groups
NathanDissoubray cd566fd
Fix some tests
NathanDissoubray 121c11d
Update test ressources in iidm 1.16
NathanDissoubray 4e978e2
Fix psse tests
NathanDissoubray 98753d9
Fix tests in iidm-modification
NathanDissoubray a06a184
Fix tests in matpower-converter
NathanDissoubray 96026ef
Fix issue with Sonar wildcard
NathanDissoubray c7e28db
Fix more sonar issues
NathanDissoubray 4e795d3
Remove last temporary limit set to 0 to check that the acceptable dur…
NathanDissoubray b9578e7
Add read the doc to explain multiple selected operational limits group
NathanDissoubray 97c5781
Exchange light and dark mode RTD images
NathanDissoubray ceae8b1
Fix identation level of example in RTD
NathanDissoubray f4d3a9b
Fix images (again)
NathanDissoubray 23043e0
Change size of text on RTD example images
NathanDissoubray d98b869
Merge branch 'main' into 3703-2-multiple_active_operational_limits_group
NathanDissoubray a570829
Add more tests for some functions in branch, for current, active and …
NathanDissoubray 0fa0140
Checkstyle
NathanDissoubray 97070d9
Use variable instead of string inside network creation of Eurostag
NathanDissoubray 429a75f
Remove duplicated lines
NathanDissoubray 2c3e4a1
Revert "Fix issue with Sonar wildcard"
NathanDissoubray a3dc713
Add some deselection tests
NathanDissoubray 7c0b8f2
Merge branch 'main' into 3703-2-multiple_active_operational_limits_group
NathanDissoubray 297cbae
Change checkPermanentLimit to check for all the selected groups, not …
NathanDissoubray c170096
Add checkAllTemporaryLimits to Utils, Branch and TieLine
NathanDissoubray dec6fd4
Change getOverloadDuration to work with multiple selected op group
NathanDissoubray 9cd09b2
Add test for getDuration
NathanDissoubray 669a546
Add a function to set all groups of a flows holder as selected
NathanDissoubray 085e95d
Move function as default in interface and remove unused util function…
NathanDissoubray b5537f3
Modify cgmes export to take into account all selected limits, add tes…
NathanDissoubray 0543682
Properly copy all selected groups when transforming a 3WT to 3-2WT
NathanDissoubray 979c8b8
Make an helper function to get limit holder from side in abstractbranch
NathanDissoubray 2728f1d
Add a selection of groups with a predicate
NathanDissoubray dd17d18
Add a test to check the add by predicate
NathanDissoubray 6a72ec5
Modify getOverload to take into account the firstTemporary limit
NathanDissoubray e48daad
Add tests for checkTemporaryLimit on branch
NathanDissoubray e93a8a3
Add some javadoc
NathanDissoubray 0930db6
Merge branch 'main' into 3703-2-multiple_active_operational_limits_group
NathanDissoubray d518bc3
Add checkTemporaryLimits test for 3WT
NathanDissoubray db9a6ae
Add tests for limitReduction on checkAllTemporaryLimits
NathanDissoubray 2980db0
Fix some javadoc and RTD
NathanDissoubray 506160b
Reword LimitViolation javadoc for acceptableDuraion to not only be va…
NathanDissoubray 2cefa50
Add null check to AbstractLimitsReducer constructor
NathanDissoubray 9da540a
Suggested code review javadoc changes
NathanDissoubray d97523e
Move checkAllTemporaryLimits(side, type) as default in Branch
NathanDissoubray ca22381
Move 3wt getOverloadDuration to interface as default, change implemen…
NathanDissoubray aa47c30
Move getAllSelectedLimits as default in ThreeWindingsTransformer
NathanDissoubray a94b8b9
Change parameter order for write/read allSelectedGroupsIds
NathanDissoubray 1c45a7d
Remove TODOs
NathanDissoubray 43827a4
Add clarification regarding setting loading limits on tie lines
NathanDissoubray f3b4a1b
Select default group if not already selected
NathanDissoubray 1b5c25f
Notify deselect only if group was selected
NathanDissoubray ee59a57
Reword javadoc of addSelectedByPredicate
NathanDissoubray 775c410
Reword "of the selected" to "of the last selected" in javadoc
NathanDissoubray d154b19
Create a wrapper to consume limitViolations
NathanDissoubray 83a9088
Checkstyle
NathanDissoubray 8a30778
Correction on wrapper of consumer in LimitViolationDetector
NathanDissoubray 810f7bb
Add a method for ordered ids of operational limit groups
NathanDissoubray f85761a
Modify addSelected and deselect to log errors / warn and only throw e…
NathanDissoubray bf3d0de
Add test on limit reduction applier to check reduction on multiple se…
NathanDissoubray 0ff4bbc
Serialize LimitViolation's operationalLimitsGroupId
NathanDissoubray 69dd53e
Add test for v1.4 of shortcircuit SerDe with an OperationalLimitsGroupId
NathanDissoubray 44fbe7e
Modify tests on v1.9 of LimitViolation SerDe to test write / read of …
NathanDissoubray 0eeceb5
Refactor some code to avoid repetition in LimitViolationUtils
NathanDissoubray 6743348
Same refactoring for permanent limits
NathanDissoubray 4ebba72
Same for permanent result
NathanDissoubray 91deb28
Merge branch 'main' into 3703-2-multiple_active_operational_limits_group
NathanDissoubray 8232a85
Adapt code after DanglingLine to BoundaryLine renaming
NathanDissoubray 7385208
Rename some forgotten dangling into boundary
NathanDissoubray 6b26366
Add test to export of network with multiple selected groups
NathanDissoubray 7e8039d
Remove TODO
NathanDissoubray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.