[To be discussed] Migration to new checkstyle

action-api/src/main/java/com/powsybl/action/PhaseTapChangerRegulationAction.java

@@ -57,11 +57,13 @@ public static PhaseTapChangerRegulationAction activateRegulation(String id, Stri
         return new PhaseTapChangerRegulationAction(id, transformerId, side, true, null, null);
     }
 
-    public static PhaseTapChangerRegulationAction activateAndChangeRegulationMode(String id, String transformerId, PhaseTapChanger.RegulationMode regulationMode, Double regulationValue) {
+    public static PhaseTapChangerRegulationAction activateAndChangeRegulationMode(String id, String transformerId,
+                                                                                  PhaseTapChanger.RegulationMode regulationMode, Double regulationValue) {
         return new PhaseTapChangerRegulationAction(id, transformerId, null, true, regulationMode, regulationValue);
     }
 
-    public static PhaseTapChangerRegulationAction activateAndChangeRegulationMode(String id, String transformerId, ThreeSides side, PhaseTapChanger.RegulationMode regulationMode, Double regulationValue) {
+    public static PhaseTapChangerRegulationAction activateAndChangeRegulationMode(String id, String transformerId, ThreeSides side,
+                                                                                  PhaseTapChanger.RegulationMode regulationMode, Double regulationValue) {
         return new PhaseTapChangerRegulationAction(id, transformerId, side, true, regulationMode, regulationValue);
     }
 

action-api/src/main/java/com/powsybl/action/json/AbstractTapChangerRegulationActionSerializer.java

@@ -9,8 +9,8 @@
 
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
-import com.powsybl.commons.json.JsonUtil;
 import com.powsybl.action.AbstractTapChangerRegulationAction;
+import com.powsybl.commons.json.JsonUtil;
 
 import java.io.IOException;
 

action-api/src/main/java/com/powsybl/action/json/AbstractTapChangerTapPositionActionSerializer.java

@@ -9,8 +9,8 @@
 
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
-import com.powsybl.commons.json.JsonUtil;
 import com.powsybl.action.AbstractTapChangerTapPositionAction;
+import com.powsybl.commons.json.JsonUtil;
 
 import java.io.IOException;
 

action-api/src/main/java/com/powsybl/action/json/ActionJsonModule.java

@@ -53,8 +53,10 @@ TerminalsConnectionAction.NAME, new TerminalsConnectionActionSerializer(),
         registerActionBuilderType(RatioTapChangerRegulationAction.class, RatioTapChangerRegulationActionBuilder.class, RatioTapChangerRegulationAction.NAME,
                 new RatioTapChangerRegulationActionSerializer(), new RatioTapChangerRegulationActionBuilderBuilderDeserializer());
         registerActionBuilderType(LoadAction.class, LoadActionBuilder.class, LoadAction.NAME, new LoadActionSerializer(), new LoadActionBuilderBuilderDeserializer());
-        registerActionBuilderType(PercentChangeLoadAction.class, PercentChangeLoadActionBuilder.class, PercentChangeLoadAction.NAME, new PercentChangeLoadActionSerializer(), new PercentChangeLoadActionBuilderDeserializer());
-        registerActionBuilderType(DanglingLineAction.class, DanglingLineActionBuilder.class, DanglingLineAction.NAME, new DanglingLineActionSerializer(), new DanglingLineActionBuilderBuilderDeserializer());
+        registerActionBuilderType(PercentChangeLoadAction.class, PercentChangeLoadActionBuilder.class,
+            PercentChangeLoadAction.NAME, new PercentChangeLoadActionSerializer(), new PercentChangeLoadActionBuilderDeserializer());
+        registerActionBuilderType(DanglingLineAction.class, DanglingLineActionBuilder.class,
+            DanglingLineAction.NAME, new DanglingLineActionSerializer(), new DanglingLineActionBuilderBuilderDeserializer());
         registerActionBuilderType(HvdcAction.class, HvdcActionBuilder.class, HvdcAction.NAME, new HvdcActionSerializer(), new HvdcActionBuilderDeserializer());
         registerActionBuilderType(GeneratorAction.class, GeneratorActionBuilder.class, GeneratorAction.NAME,
                 new GeneratorActionSerializer(), new GeneratorActionBuilderDeserializer());

action-api/src/main/java/com/powsybl/action/json/ActionListDeserializer.java

@@ -12,11 +12,11 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+import com.powsybl.action.Action;
 import com.powsybl.action.ActionBuilder;
+import com.powsybl.action.ActionList;
 import com.powsybl.action.IdentifierActionList;
 import com.powsybl.commons.json.JsonUtil;
-import com.powsybl.action.Action;
-import com.powsybl.action.ActionList;
 import com.powsybl.iidm.network.identifiers.NetworkElementIdentifier;
 
 import java.io.IOException;
@@ -45,31 +45,7 @@ public static class ParsingContext {
     @Override
     public ActionList deserialize(JsonParser parser, DeserializationContext deserializationContext) throws IOException {
         ParsingContext context = new ParsingContext();
-        JsonUtil.parseObject(parser, fieldName -> {
-            switch (fieldName) {
-                case VERSION:
-                    context.version = parser.nextTextValue();
-                    deserializationContext.setAttribute(VERSION, context.version);
-                    return true;
-                case "actions":
-                    parser.nextToken();
-                    List<ActionBuilder> actionBuilders = JsonUtil.readList(deserializationContext, parser, ActionBuilder.class);
-                    context.actions = actionBuilders.stream().map(ActionBuilder::build).toList();
-                    return true;
-                case "elementIdentifiers":
-                    parser.nextToken();
-                    context.elementIdentifierMap = parser.readValueAs(new TypeReference<HashMap<String, NetworkElementIdentifier>>() {
-                    });
-                    return true;
-                case "actionBuilders":
-                    parser.nextToken();
-                    context.actionBuilderMap = parser.readValueAs(new TypeReference<HashMap<String, ActionBuilder>>() {
-                    });
-                    return true;
-                default:
-                    return false;
-            }
-        });
+        JsonUtil.parseObject(parser, fieldName -> parseActionList(parser, deserializationContext, context, fieldName));
         if (context.version == null) {
             throw new JsonMappingException(parser, "version is missing");
         }
@@ -88,4 +64,30 @@ public ActionList deserialize(JsonParser parser, DeserializationContext deserial
         }
         return new ActionList(context.actions);
     }
+
+    private boolean parseActionList(JsonParser parser, DeserializationContext deserializationContext, ParsingContext context, String fieldName) throws IOException {
+        switch (fieldName) {
+            case VERSION:
+                context.version = parser.nextTextValue();
+                deserializationContext.setAttribute(VERSION, context.version);
+                return true;
+            case "actions":
+                parser.nextToken();
+                List<ActionBuilder> actionBuilders = JsonUtil.readList(deserializationContext, parser, ActionBuilder.class);
+                context.actions = actionBuilders.stream().map(ActionBuilder::build).toList();
+                return true;
+            case "elementIdentifiers":
+                parser.nextToken();
+                context.elementIdentifierMap = parser.readValueAs(new TypeReference<HashMap<String, NetworkElementIdentifier>>() {
+                });
+                return true;
+            case "actionBuilders":
+                parser.nextToken();
+                context.actionBuilderMap = parser.readValueAs(new TypeReference<HashMap<String, ActionBuilder>>() {
+                });
+                return true;
+            default:
+                return false;
+        }
+    }
 }

action-api/src/main/java/com/powsybl/action/json/AreaInterchangeTargetActionDeserializer.java

@@ -29,27 +29,29 @@ protected AreaInterchangeTargetActionDeserializer() {
     @Override
     public AreaInterchangeTargetActionBuilder deserialize(JsonParser jsonParser, DeserializationContext deserializationContext) throws IOException {
         AreaInterchangeTargetActionBuilder builder = new AreaInterchangeTargetActionBuilder();
-        JsonUtil.parsePolymorphicObject(jsonParser, name -> {
-            switch (name) {
-                case "type":
-                    if (!AreaInterchangeTargetAction.NAME.equals(jsonParser.nextTextValue())) {
-                        throw JsonMappingException.from(jsonParser, "Expected type " + AreaInterchangeTargetAction.NAME);
-                    }
-                    return true;
-                case "id":
-                    builder.withId(jsonParser.nextTextValue());
-                    return true;
-                case "areaId":
-                    builder.withAreaId(jsonParser.nextTextValue());
-                    return true;
-                case "interchangeTarget":
-                    jsonParser.nextToken();
-                    builder.withTarget(jsonParser.getValueAsDouble());
-                    return true;
-                default:
-                    return false;
-            }
-        });
+        JsonUtil.parsePolymorphicObject(jsonParser, name -> parseAreaInterchangeTargetAction(jsonParser, builder, name));
         return builder;
     }
+
+    private boolean parseAreaInterchangeTargetAction(JsonParser jsonParser, AreaInterchangeTargetActionBuilder builder, String name) throws IOException {
+        switch (name) {
+            case "type":
+                if (!AreaInterchangeTargetAction.NAME.equals(jsonParser.nextTextValue())) {
+                    throw JsonMappingException.from(jsonParser, "Expected type " + AreaInterchangeTargetAction.NAME);
+                }
+                return true;
+            case "id":
+                builder.withId(jsonParser.nextTextValue());
+                return true;
+            case "areaId":
+                builder.withAreaId(jsonParser.nextTextValue());
+                return true;
+            case "interchangeTarget":
+                jsonParser.nextToken();
+                builder.withTarget(jsonParser.getValueAsDouble());
+                return true;
+            default:
+                return false;
+        }
+    }
 }

action-api/src/main/java/com/powsybl/action/json/GeneratorActionBuilderDeserializer.java

@@ -11,9 +11,9 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
-import com.powsybl.commons.json.JsonUtil;
 import com.powsybl.action.GeneratorAction;
 import com.powsybl.action.GeneratorActionBuilder;
+import com.powsybl.commons.json.JsonUtil;
 
 import java.io.IOException;
 
@@ -29,43 +29,45 @@ public GeneratorActionBuilderDeserializer() {
     @Override
     public GeneratorActionBuilder deserialize(JsonParser parser, DeserializationContext deserializationContext) throws IOException {
         GeneratorActionBuilder generatorActionBuilder = new GeneratorActionBuilder();
-        JsonUtil.parsePolymorphicObject(parser, name -> {
-            switch (name) {
-                case "type":
-                    if (!GeneratorAction.NAME.equals(parser.nextTextValue())) {
-                        throw JsonMappingException.from(parser, "Expected type " + GeneratorAction.NAME);
-                    }
-                    return true;
-                case "id":
-                    generatorActionBuilder.withId(parser.nextTextValue());
-                    return true;
-                case "generatorId":
-                    generatorActionBuilder.withGeneratorId(parser.nextTextValue());
-                    return true;
-                case "activePowerRelativeValue":
-                    parser.nextToken();
-                    generatorActionBuilder.withActivePowerRelativeValue(parser.getValueAsBoolean());
-                    return true;
-                case "activePowerValue":
-                    parser.nextToken();
-                    generatorActionBuilder.withActivePowerValue(parser.getValueAsDouble());
-                    return true;
-                case "voltageRegulatorOn":
-                    parser.nextToken();
-                    generatorActionBuilder.withVoltageRegulatorOn(parser.getValueAsBoolean());
-                    return true;
-                case "targetV":
-                    parser.nextToken();
-                    generatorActionBuilder.withTargetV(parser.getValueAsDouble());
-                    return true;
-                case "targetQ":
-                    parser.nextToken();
-                    generatorActionBuilder.withTargetQ(parser.getValueAsDouble());
-                    return true;
-                default:
-                    return false;
-            }
-        });
+        JsonUtil.parsePolymorphicObject(parser, name -> parseGeneratorAction(parser, generatorActionBuilder, name));
         return generatorActionBuilder;
     }
+
+    private boolean parseGeneratorAction(JsonParser parser, GeneratorActionBuilder generatorActionBuilder, String name) throws IOException {
+        switch (name) {
+            case "type":
+                if (!GeneratorAction.NAME.equals(parser.nextTextValue())) {
+                    throw JsonMappingException.from(parser, "Expected type " + GeneratorAction.NAME);
+                }
+                return true;
+            case "id":
+                generatorActionBuilder.withId(parser.nextTextValue());
+                return true;
+            case "generatorId":
+                generatorActionBuilder.withGeneratorId(parser.nextTextValue());
+                return true;
+            case "activePowerRelativeValue":
+                parser.nextToken();
+                generatorActionBuilder.withActivePowerRelativeValue(parser.getValueAsBoolean());
+                return true;
+            case "activePowerValue":
+                parser.nextToken();
+                generatorActionBuilder.withActivePowerValue(parser.getValueAsDouble());
+                return true;
+            case "voltageRegulatorOn":
+                parser.nextToken();
+                generatorActionBuilder.withVoltageRegulatorOn(parser.getValueAsBoolean());
+                return true;
+            case "targetV":
+                parser.nextToken();
+                generatorActionBuilder.withTargetV(parser.getValueAsDouble());
+                return true;
+            case "targetQ":
+                parser.nextToken();
+                generatorActionBuilder.withTargetQ(parser.getValueAsDouble());
+                return true;
+            default:
+                return false;
+        }
+    }
 }

action-api/src/main/java/com/powsybl/action/json/HvdcActionBuilderDeserializer.java

@@ -11,10 +11,10 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
-import com.powsybl.commons.json.JsonUtil;
-import com.powsybl.iidm.network.HvdcLine;
 import com.powsybl.action.HvdcAction;
 import com.powsybl.action.HvdcActionBuilder;
+import com.powsybl.commons.json.JsonUtil;
+import com.powsybl.iidm.network.HvdcLine;
 
 import java.io.IOException;
 
@@ -30,46 +30,48 @@ public HvdcActionBuilderDeserializer() {
     @Override
     public HvdcActionBuilder deserialize(JsonParser jsonParser, DeserializationContext deserializationContext) throws IOException {
         HvdcActionBuilder hvdcActionBuilder = new HvdcActionBuilder();
-        JsonUtil.parsePolymorphicObject(jsonParser, name -> {
-            switch (name) {
-                case "type":
-                    if (!HvdcAction.NAME.equals(jsonParser.nextTextValue())) {
-                        throw JsonMappingException.from(jsonParser, "Expected type " + HvdcAction.NAME);
-                    }
-                    return true;
-                case "id":
-                    hvdcActionBuilder.withId(jsonParser.nextTextValue());
-                    return true;
-                case "hvdcId":
-                    hvdcActionBuilder.withHvdcId(jsonParser.nextTextValue());
-                    return true;
-                case "acEmulationEnabled":
-                    jsonParser.nextToken();
-                    hvdcActionBuilder.withAcEmulationEnabled(jsonParser.getValueAsBoolean());
-                    return true;
-                case "activePowerSetpoint":
-                    jsonParser.nextToken();
-                    hvdcActionBuilder.withActivePowerSetpoint(jsonParser.getValueAsDouble());
-                    return true;
-                case "converterMode":
-                    hvdcActionBuilder.withConverterMode(HvdcLine.ConvertersMode.valueOf(jsonParser.nextTextValue()));
-                    return true;
-                case "droop":
-                    jsonParser.nextToken();
-                    hvdcActionBuilder.withDroop(jsonParser.getValueAsDouble());
-                    return true;
-                case "p0":
-                    jsonParser.nextToken();
-                    hvdcActionBuilder.withP0(jsonParser.getValueAsDouble());
-                    return true;
-                case "relativeValue":
-                    jsonParser.nextToken();
-                    hvdcActionBuilder.withRelativeValue(jsonParser.getValueAsBoolean());
-                    return true;
-                default:
-                    return false;
-            }
-        });
+        JsonUtil.parsePolymorphicObject(jsonParser, name -> parseHvdcAction(jsonParser, hvdcActionBuilder, name));
         return hvdcActionBuilder;
     }
+
+    private boolean parseHvdcAction(JsonParser jsonParser, HvdcActionBuilder hvdcActionBuilder, String name) throws IOException {
+        switch (name) {
+            case "type":
+                if (!HvdcAction.NAME.equals(jsonParser.nextTextValue())) {
+                    throw JsonMappingException.from(jsonParser, "Expected type " + HvdcAction.NAME);
+                }
+                return true;
+            case "id":
+                hvdcActionBuilder.withId(jsonParser.nextTextValue());
+                return true;
+            case "hvdcId":
+                hvdcActionBuilder.withHvdcId(jsonParser.nextTextValue());
+                return true;
+            case "acEmulationEnabled":
+                jsonParser.nextToken();
+                hvdcActionBuilder.withAcEmulationEnabled(jsonParser.getValueAsBoolean());
+                return true;
+            case "activePowerSetpoint":
+                jsonParser.nextToken();
+                hvdcActionBuilder.withActivePowerSetpoint(jsonParser.getValueAsDouble());
+                return true;
+            case "converterMode":
+                hvdcActionBuilder.withConverterMode(HvdcLine.ConvertersMode.valueOf(jsonParser.nextTextValue()));
+                return true;
+            case "droop":
+                jsonParser.nextToken();
+                hvdcActionBuilder.withDroop(jsonParser.getValueAsDouble());
+                return true;
+            case "p0":
+                jsonParser.nextToken();
+                hvdcActionBuilder.withP0(jsonParser.getValueAsDouble());
+                return true;
+            case "relativeValue":
+                jsonParser.nextToken();
+                hvdcActionBuilder.withRelativeValue(jsonParser.getValueAsBoolean());
+                return true;
+            default:
+                return false;
+        }
+    }
 }

action-api/src/main/java/com/powsybl/action/json/HvdcActionSerializer.java

@@ -10,8 +10,8 @@
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
-import com.powsybl.commons.json.JsonUtil;
 import com.powsybl.action.HvdcAction;
+import com.powsybl.commons.json.JsonUtil;
 
 import java.io.IOException;
 

action-api/src/main/java/com/powsybl/action/json/MultipleActionsActionBuilderDeserializer.java

@@ -12,9 +12,9 @@
 import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import com.powsybl.action.ActionBuilder;
+import com.powsybl.action.MultipleActionsAction;
 import com.powsybl.action.MultipleActionsActionBuilder;
 import com.powsybl.commons.json.JsonUtil;
-import com.powsybl.action.MultipleActionsAction;
 
 import java.io.IOException;