Skip to content

Conversation

@samirromdhani
Copy link
Contributor

@samirromdhani samirromdhani commented Jan 30, 2026

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #1160

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

In IIDM 1.16, the XML/JSON element name for shunt compensators has been renamed from shunt to shuntCompensator. As a result:

  • IIDM v1.16 files must use <iidm:shuntCompensator>.
  • The old tag name <iidm:shunt> is no longer compatible in v1.16.
  • Exporting with version 1.16 will always write <iidm:shuntCompensator>.
  • To keep the old tag, export using IIDM v1.15 or older.

@samirromdhani samirromdhani force-pushed the feat/1160_rename_shunt_to_shunt_compensator branch 2 times, most recently from 5e0c1e0 to 3b06603 Compare February 2, 2026 08:42
@samirromdhani samirromdhani self-assigned this Feb 2, 2026
@samirromdhani samirromdhani force-pushed the feat/1160_rename_shunt_to_shunt_compensator branch 5 times, most recently from a728835 to 7d183cf Compare February 2, 2026 14:02
BREAKING CHANGE: ⚠️  Rename Shunt to ShuntCompensator

Signed-off-by: Samir Romdhani <[email protected]>

feat(IIDM): Added V1_17 test files [rename shunt to shuntCompensator]

Signed-off-by: Samir Romdhani <[email protected]>

feat(IIDM): reduced cognitive complexity [sonar] [rename shunt to shuntCompensator]

Signed-off-by: Samir Romdhani <[email protected]>

feat(IIDM): Rename Shunt to Shunt Compensator on v1.16

Signed-off-by: Samir Romdhani <[email protected]>
@samirromdhani samirromdhani force-pushed the feat/1160_rename_shunt_to_shunt_compensator branch from 7d183cf to 13fdda8 Compare February 2, 2026 14:57
@github-project-automation github-project-automation bot moved this from TODO to Waiting for review in Release 03/2026 Feb 3, 2026
@olperr1 olperr1 moved this from Waiting for review to In Progress in Release 03/2026 Feb 3, 2026
@samirromdhani samirromdhani marked this pull request as ready for review February 3, 2026 10:18
Signed-off-by: Samir Romdhani <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Shunt Compensator are called "shunt" on XIIDM files

3 participants