-
Notifications
You must be signed in to change notification settings - Fork 52
Optimize getFictitiousP0() and getFictitiousQ0() to compute over every nodes only when needed #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SylvestreSakti
wants to merge
10
commits into
main
Choose a base branch
from
node_breaker_has_fictitious
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a614bc4
Add hasFictitiousP0() and hasFictitiousQ0()
SylvestreSakti 26148a3
Remarks from review
SylvestreSakti 9f0777d
Review from remarks and comments
SylvestreSakti 5a668cc
Move from VoltageLevel API to VoltageLevelExt
SylvestreSakti 6d21432
Fix error
SylvestreSakti bac949d
Remove duplication
SylvestreSakti 4659b31
remove default method
SylvestreSakti 8dab8bc
Add unit test
SylvestreSakti 449e2c7
Add coverage
SylvestreSakti 9c956ec
Checkstyle
SylvestreSakti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -645,6 +645,21 @@ void removeSwitchFromTopology(String switchId, boolean notify) { | |
| private final TIntObjectMap<TDoubleArrayList> fictitiousP0ByNode = TCollections.synchronizedMap(new TIntObjectHashMap<>()); | ||
| private final TIntObjectMap<TDoubleArrayList> fictitiousQ0ByNode = TCollections.synchronizedMap(new TIntObjectHashMap<>()); | ||
|
|
||
| @Override | ||
| public boolean hasFictitiousP0() { | ||
| if (fictitiousP0ByNode.isEmpty()) { | ||
| return false; | ||
| } | ||
| int variantIndex = getNetwork().getVariantIndex(); | ||
| for (int node : fictitiousP0ByNode.keys()) { | ||
| TDoubleArrayList p0ByVariant = fictitiousP0ByNode.get(node); | ||
| if (p0ByVariant != null && p0ByVariant.get(variantIndex) != 0.0) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
|
||
| } | ||
|
|
||
| @Override | ||
| public double getFictitiousP0(int node) { | ||
| TDoubleArrayList fictP0 = fictitiousP0ByNode.get(node); | ||
|
|
@@ -684,6 +699,21 @@ public VoltageLevel.NodeBreakerView setFictitiousP0(int node, double p0) { | |
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasFictitiousQ0() { | ||
| if (fictitiousQ0ByNode.isEmpty()) { | ||
| return false; | ||
| } | ||
| int variantIndex = getNetwork().getVariantIndex(); | ||
| for (int node : fictitiousQ0ByNode.keys()) { | ||
| TDoubleArrayList p0ByVariant = fictitiousQ0ByNode.get(node); | ||
| if (p0ByVariant != null && p0ByVariant.get(variantIndex) != 0.0) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public double getFictitiousQ0(int node) { | ||
| TDoubleArrayList fictQ0 = fictitiousQ0ByNode.get(node); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.