Skip to content

Create schema specific to the version to validate#3801

Open
samirromdhani wants to merge 12 commits intomainfrom
feat/2818-create-schema-specific-to-the-version-to-validate
Open

Create schema specific to the version to validate#3801
samirromdhani wants to merge 12 commits intomainfrom
feat/2818-create-schema-specific-to-the-version-to-validate

Conversation

@samirromdhani
Copy link
Contributor

@samirromdhani samirromdhani commented Mar 2, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #2818

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

  • Some extension XSD files reference IIDM XSD files from other versions (xs:import + schemaLocation), which can impact schema resolution . To handle this, extractSchemaLocations and getSupportedExtensionsByIIdmVersion were added.
  • To make version validation strict, we verify the root namespace first, then run XSD validation, this is handled by readRootNamespace and checkNamespace

@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch 3 times, most recently from 33132c3 to 65f0051 Compare March 3, 2026 16:10
@samirromdhani samirromdhani self-assigned this Mar 3, 2026
@samirromdhani samirromdhani changed the title WIP Create schema specific to the version to validate Create schema specific to the version to validate Mar 3, 2026
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch from c76619e to a2cfa27 Compare March 4, 2026 10:03
@samirromdhani samirromdhani marked this pull request as ready for review March 4, 2026 10:29
@samirromdhani samirromdhani marked this pull request as draft March 4, 2026 10:52
@samirromdhani samirromdhani marked this pull request as ready for review March 4, 2026 10:57
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch from ccfe442 to b356226 Compare March 4, 2026 12:32
@samirromdhani samirromdhani requested review from olperr1 and rolnico March 4, 2026 12:33
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch from b356226 to fe0aa21 Compare March 4, 2026 12:46
@samirromdhani samirromdhani marked this pull request as draft March 5, 2026 08:23
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch 2 times, most recently from fdea43a to 0180fc2 Compare March 5, 2026 16:14
@samirromdhani samirromdhani marked this pull request as ready for review March 5, 2026 16:15
@samirromdhani samirromdhani marked this pull request as draft March 6, 2026 08:27
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch 11 times, most recently from f4d0545 to e44b19b Compare March 9, 2026 10:45
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch from e44b19b to 59d72cb Compare March 9, 2026 13:35
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch from 59d72cb to 5dce9ad Compare March 9, 2026 14:06
@samirromdhani
WIP
f1e1f3f 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

validate specific version WIP

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
xsd validation by specific version, when extensions WIP
838b111 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
extensions
d3c0adc 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
fix extensions specific to the version to validate
316ac00 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
test extensions specific to the version to validate
5e4e240 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
add test cases: invalid extension and ns not match expected version
b6c2c05 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
fix sonar
bfacb0f 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
review notes
c4bbb7d 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
review improve extractSchemaLocations and centralize SchemaFactory cr…
735425c 
…eation in XmlUtil

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

review: centralize SchemaFactory creation in XmlUtil

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
review: keep use memoized ConcurrentMap and computeIfAbsent for lazy …
3b02211 
…schema cache

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
review sonar, add tests
548d4f8 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

fixes sonar
@samirromdhani
fixes sonar
c4dafdb 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the feat/2818-create-schema-specific-to-the-version-to-validate branch from 5dce9ad to c4dafdb Compare March 9, 2026 14:21
@samirromdhani samirromdhani marked this pull request as ready for review March 9, 2026 14:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olperr1 olperr1 Awaiting requested review from olperr1

@rolnico rolnico Awaiting requested review from rolnico

At least 1 approving review is required to merge this pull request.

Assignees

@samirromdhani samirromdhani

Labels

XIIDM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create schema specific to the version to validate

1 participant

@samirromdhani