Skip to content

WIP improve condition readability (loadflow-validation)#3830

Draft
samirromdhani wants to merge 17 commits intomainfrom
refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation
Draft

WIP improve condition readability (loadflow-validation)#3830
samirromdhani wants to merge 17 commits intomainfrom
refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation

Conversation

@samirromdhani
Copy link
Contributor

@samirromdhani samirromdhani commented Mar 18, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #246

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Done
  • Improve Generator validation rules
  • Fixed gaps between code and doc for Generator
  • Improved SVC validation rules
  • Fixed gaps between code and doc for Shunt and SVC
  • Improved ShuntCompensator validation rules
WIP TODO
  • Improve Buses validation rules
  • Improve Flow validation rules (Branch Data :Line, TWT, TieLine)
  • Improve TWT validation rules
  • Improve 3WT validation rules

@samirromdhani
refactor(loadflow-validation): WIP improve condition readability
4ea0788 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch from 9bbef00 to 4ea0788 Compare March 18, 2026 15:24
@samirromdhani
review conditions in ShuntCompensators validation WIP
b885258 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch from 46f34a5 to 786b83b Compare March 19, 2026 14:14
@samirromdhani
refactor(loadflow-validation): remove duplicated code
9903454 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 3 times, most recently from 95bed9a to 6091103 Compare March 20, 2026 14:12
@samirromdhani samirromdhani mentioned this pull request Mar 20, 2026
Open
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 2 times, most recently from 6d7b3f7 to da96b43 Compare March 20, 2026 14:39
@samirromdhani
ShuntCompensator validation review, prepare actions
5768c19 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 4 times, most recently from 7df0bf1 to b8f2d6b Compare March 20, 2026 16:38
@samirromdhani
ShuntCompensator validation review, prepare example
2f721d6 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 4 times, most recently from 6e827ec to 0cb140c Compare March 23, 2026 10:19
@samirromdhani
SVC validation review
b2d959d 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch from 0cb140c to b2d959d Compare March 23, 2026 10:22
@samirromdhani
SVC validation review, prepare actions
a5c5ced 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 3 times, most recently from 4b8135c to c7b56fc Compare March 23, 2026 14:57
@samirromdhani
Generators validation review
96843f0 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch from c7b56fc to 96843f0 Compare March 23, 2026 14:59
@samirromdhani
Buses validation review
8ce175a 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
notes Flows, TWT and 2W TWT validation
5f24bb2 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
improve ShuntCompensator validation rules
c3d51eb 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 3 times, most recently from bf3f14a to e7d56fd Compare March 24, 2026 12:33
@samirromdhani samirromdhani self-assigned this Mar 24, 2026
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 10 times, most recently from 0aefe4b to af31f1d Compare March 24, 2026 16:07
@samirromdhani
improve SVC validation rules wip
4c4e8ea 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

note

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

improve SVC validation rules wip

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
fix gaps between current code and current doc for Shunt and SVC
c17af49 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>

fix gaps between current code and current doc (Shunt Compensator)

Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
improve SVC validation rules
4667241 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch 4 times, most recently from a0a471b to 68632e2 Compare March 25, 2026 14:29
@samirromdhani
improve Generator validation rules
9389f8d 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani samirromdhani force-pushed the refactor/246-enhance-the-readability-of-the-conditions-in-loadflow-validation branch from 68632e2 to 9389f8d Compare March 25, 2026 14:42
samirromdhani
samirromdhani commented Mar 25, 2026
View reviewed changes
loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/ValidationUtils.java
}

/**
* Generator: rule for valid result <code> | targetQ - Q | < threshold </code>
Copy link
Contributor Author

@samirromdhani samirromdhani Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aligned with the doc

@samirromdhani
resume SVC rules for valid results
eb54d24 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@samirromdhani
resume Generator rules for valid results
7a46c3c 
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 26, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@samirromdhani samirromdhani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance the readability of the conditions in loadflow-validation

1 participant

@samirromdhani