Updates LimitViolationBuilder to reflect changes in LimitViolation

[Noor-Mustafa123]

….java

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #3813

What kind of change does this PR introduce?

Replacement of overloaded constructors with builder in LimitViolation.java

What is the current behavior?

uses overloaded constructors

What is the new behavior (if this is a feature change)?
uses builder pattern

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

If yes, please check if the following requirements are fulfilled

• The Breaking Change or Deprecated label has been added
• The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

[NathanDissoubray]

It seems like you didn't setup the DCO, please see https://github.com/powsybl/powsybl-core/pull/3832/checks?check_run_id=67722763487 for an explanation and how to fix this issue.

[Noor-Mustafa123]

It seems like you didn't setup the DCO, please see https://github.com/powsybl/powsybl-core/pull/3832/checks?check_run_id=67722763487 for an explanation and how to fix this issue.

commit is now signed

[NathanDissoubray]

That seems good to me apart from a change in tests.
I'm actually wondering if the LimitViolationBuilder should be in LimitViolation instead of a separate class, as I don't see a reason for it to be separate.
I also find it confusing how it's done currently, with both new in LimitViolation and a Builder in separate class.

@olperr1 do you think we should move the builder inside LimitViolation and remove the constructors of LimitViolation ? That would be a breaking change (so only for next release), but I think it'll be better to not have too many ways to make a LimitViolation

[Noor-Mustafa123]

@NathanDissoubray can you guide me on how ot merge this PR dont have permission currently do i have to ask a maintainer to merge my PR?

[NathanDissoubray]

@Noor-Mustafa123 one of the maintainer will review your PR (I'm not maintainer), will start the CI if everything seems fine, and if it passes and they don't want any changes, will approve and merge it.
They might not be available right now as we are in the release phase of PowSybBl 7.2.0 and they are occupied with this for the moment.